kasakrisz commented on PR #5283: URL: https://github.com/apache/hive/pull/5283#issuecomment-2210338444
In the test [cbo_aggregate_reduce_functions_rule.q](https://github.com/apache/hive/blob/b15ce9126dcc596c953fe202e6834cebdfca6080/ql/src/test/queries/clientpositive/cbo_aggregate_reduce_functions_rule.q#L57-L62) aggregate functions under test (sum, count, stddev*, etc) are wrapped into a `round` function call. I understand the reason however I think it can cause some noise: if an expression like ``` ROUND(SUM(c_numeric), 3) ``` returns invalid result it can have multiple reasons: `sum` is wrong or `round` is wrong or both. In theory if both are wrong as a side effect the expression itself can return a good result in some cases hence a potential bug in both function implementations remains hidden. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
