okumin commented on PR #5283: URL: https://github.com/apache/hive/pull/5283#issuecomment-2212442938
@kasakrisz I don't have any objections. The original intention is human-readability and floating-point error mitigation. [I tried to remove ROUND](https://github.com/apache/hive/pull/5283/commits/8b8136e4c856c276778874710d8eccb06a278152). To be fair, we observe difference between CBO and non-CBO. ``` < +228.0 228.0 0.0 0.0 193.0 193.0 28.5 28.5 NULL NULL 32.166666666666664 32.166666666666664 47.34448225506326 47.34448225506326 NULL NULL 53.52387836802893 53.52387836802893 50.61338050075578 50.61338050075578 NULL NULL 58.63247109466449 58.63247109466449 2241.5 2241.5 NULL NULL 2864.805555555555 2864.805555555555 2561.714285714286 2561.714285714286 NULL NULL 3437.7666666666664 3437.7666666666664 228.0 228.0 NULL NULL 193.0 193.0 8 8 8 0 8 6 --- > +228.0 228.0 0.0 0.0 193.0 193.0 28.5 28.5 NULL NULL 32.166666666666664 32.166666666666664 47.34448225506326 47.34448225506326 NULL NULL 53.52387836802894 53.52387836802894 50.61338050075578 50.61338050075578 NULL NULL 58.632471094664496 58.632471094664496 2241.5 2241.5 NULL NULL 2864.805555555556 2864.805555555556 2561.714285714286 2561.714285714286 NULL NULL 3437.7666666666673 3437.7666666666673 228.0 228.0 NULL NULL 193.0 193.0 8 8 8 0 8 6 ``` For better visibility, ``` < 53.52387836802893 < 53.52387836802893 --- > 53.52387836802894 > 53.52387836802894 71,72c71,72 < 58.63247109466449 < 58.63247109466449 --- > 58.632471094664496 > 58.632471094664496 77,78c77,78 < 2864.805555555555 < 2864.805555555555 --- > 2864.805555555556 > 2864.805555555556 83,84c83,84 < 3437.7666666666664 < 3437.7666666666664 --- > 3437.7666666666673 > 3437.7666666666673 ``` I presume they are acceptable as floating-point errors. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
