deniskuzZ commented on code in PR #5254:
URL: https://github.com/apache/hive/pull/5254#discussion_r1671772380
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/IcebergAcidUtil.java:
##########
@@ -252,13 +289,63 @@ public boolean hasNext() {
public T next() {
T next = currentIterator.next();
GenericRecord rec = (GenericRecord) next;
+ IcebergAcidUtil.copyFields(rec, FILE_READ_META_COLS.size(),
current.size(), current);
+ int specId = IcebergAcidUtil.parseSpecId(rec);
PositionDeleteInfo.setIntoConf(conf,
- IcebergAcidUtil.parseSpecId(rec),
+ specId,
IcebergAcidUtil.computePartitionHash(rec),
IcebergAcidUtil.parseFilePath(rec),
- IcebergAcidUtil.parseFilePosition(rec));
- IcebergAcidUtil.copyFields(rec, FILE_READ_META_COLS.size(),
current.size(), current);
+ IcebergAcidUtil.parseFilePosition(rec),
+ IcebergAcidUtil.getSerializedPartitionKey(current,
table.specs().get(specId)));
return (T) current;
}
}
+
+ public static class MergeVirtualColumnAwareIterator<T> implements
CloseableIterator<T> {
+
+ private final CloseableIterator<T> currentIterator;
+ private GenericRecord current;
+ private final Schema expectedSchema;
+ private final Configuration conf;
+ private final int specId;
Review Comment:
not required, you can get it from `partitionSpec.specId()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
