SourabhBadhya commented on code in PR #5254:
URL: https://github.com/apache/hive/pull/5254#discussion_r1675305589
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/IcebergAcidUtil.java:
##########
@@ -64,13 +70,17 @@ private IcebergAcidUtil() {
private static final Types.NestedField PARTITION_HASH_META_COL =
Types.NestedField.required(
MetadataColumns.PARTITION_COLUMN_ID,
MetadataColumns.PARTITION_COLUMN_NAME, Types.LongType.get());
+
+ public static final Types.NestedField PARTITION_PROJECTION =
Types.NestedField.required(
+ Integer.MAX_VALUE - 6, "partition_projection", Types.StringType.get());
Review Comment:
Setting a unique integer for partition projection since a unique integer is
required for schema.
Particularly Integer.MAX_VALUE - 6 because the current set of predefined
list of constants for Iceberg columns have come to Integer.MAX_VALUE - 5.
https://github.com/apache/iceberg/blob/5455d30d9b6e0409d517138e9b80d6831ffb233b/core/src/main/java/org/apache/iceberg/MetadataColumns.java#L56
However, this can be any unique constant as per choice.
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java:
##########
@@ -2112,4 +2119,11 @@ public List<FileStatus>
getMergeTaskInputFiles(Properties properties) throws IOE
public MergeTaskProperties getMergeTaskProperties(Properties properties) {
return new IcebergMergeTaskProperties(properties);
}
+
+ public void setCustomDeleteProperties(TableDesc tableDesc) {
+ tableDesc.getProperties().put(InputFormatConfig.OPERATION_TYPE_PREFIX +
tableDesc.getTableName(),
Review Comment:
`OPERATION_TYPE_PREFIX` is used while configuring job conf.
Whereas `WRITE_OPERATION_CONFIG_PREFIX` is used during delete record writer
creation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
