deniskuzZ commented on code in PR #5254:
URL: https://github.com/apache/hive/pull/5254#discussion_r1687855879
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/vector/HiveBatchIterator.java:
##########
@@ -123,6 +124,13 @@ private void advance() {
lcv.isRepeating = false;
System.arraycopy(value, 0, lcv.vector, 0, batch.size);
break;
+ // Do not fill anything while evaluating deletes.
Review Comment:
why do we need this comment? i don't see any checks for deletes here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
