deniskuzZ commented on code in PR #5254:
URL: https://github.com/apache/hive/pull/5254#discussion_r1688098096
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java:
##########
@@ -321,6 +323,18 @@ public void configureJobConf(TableDesc tableDesc, JobConf
jobConf) {
jobConf.set(opKey, tableDesc.getProperties().getProperty(opKey));
Preconditions.checkArgument(!tableName.contains(TABLE_NAME_SEPARATOR),
"Can not handle table " + tableName + ". Its name contains '" +
TABLE_NAME_SEPARATOR + "'");
+ if (tableDesc.getTableDescProperty(
Review Comment:
what if we create an overloaded method for Properties?
````
String operation =
HiveCustomStorageHandlerUtils.getWriteOperation(tableDesc.getProperties(),
tableName);
if (operation != null) {
HiveCustomStorageHandlerUtils.setWriteOperation(jobConf, tableName,
operation);
}
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
