deniskuzZ commented on code in PR #5328:
URL: https://github.com/apache/hive/pull/5328#discussion_r1688285637
##########
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/storage/compact/AlterTableCompactOperation.java:
##########
@@ -89,7 +90,8 @@ public AlterTableCompactOperation(DDLOperationContext
context, AlterTableCompact
}
//Will directly initiate compaction if an un-partitioned table/a partition
is specified in the request
- if (desc.getPartitionSpec() != null || !table.isPartitioned()) {
+ if (desc.getPartitionSpec() != null || (!table.isPartitioned() &&
!DDLUtils.isIcebergTable(table) ) ||
Review Comment:
could we simplify
````
!(table.isPartitioned() || table.getStorageHandler().isPartitioned(table))
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
