difin commented on code in PR #5328:
URL: https://github.com/apache/hive/pull/5328#discussion_r1688475155
##########
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/storage/compact/AlterTableCompactOperation.java:
##########
@@ -135,7 +145,7 @@ private List<Partition> getPartitions(Table table,
AlterTableCompactDesc desc, D
List<Partition> partitions = new ArrayList<>();
if (desc.getPartitionSpec() == null) {
- if (table.isPartitioned()) {
+ if (table.isPartitioned() || (DDLUtils.isIcebergTable(table) &&
table.getStorageHandler().isPartitioned(table))) {
Review Comment:
because `table.isPartitioned()` does not work for Iceberg. For Iceberg it
will always return False. That's why I added a call to
getStorageHandler().isPartitioned(table).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
