deniskuzZ commented on code in PR #5328: URL: https://github.com/apache/hive/pull/5328#discussion_r1700053557
########## ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveStorageHandler.java: ########## @@ -778,10 +778,28 @@ default Optional<ErrorMsg> isEligibleForCompaction(org.apache.hadoop.hive.ql.met throw new UnsupportedOperationException("Storage handler does not support validating eligibility for compaction"); } + /** + * Returns partitions names for the current table spec that correspond to the provided partition spec. + * @param hmsTable {@link org.apache.hadoop.hive.ql.metadata.Table} table metadata stored in Hive Metastore + * @param partitionSpec Map of Strings {@link java.util.Map} partition specification + * @return Optional of ErrorMsg {@link org.apache.hadoop.hive.ql.ErrorMsg} Review Comment: is that copy-paste? it returns a list -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org