deniskuzZ commented on code in PR #5328:
URL: https://github.com/apache/hive/pull/5328#discussion_r1700040042
##########
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/storage/compact/AlterTableCompactOperation.java:
##########
@@ -89,7 +90,8 @@ public AlterTableCompactOperation(DDLOperationContext
context, AlterTableCompact
}
//Will directly initiate compaction if an un-partitioned table/a partition
is specified in the request
- if (desc.getPartitionSpec() != null || !table.isPartitioned()) {
+ if (desc.getPartitionSpec() != null || (!table.isPartitioned() &&
!DDLUtils.isIcebergTable(table) ) ||
Review Comment:
`!(table.isPartitioned() || DDLUtils.isIcebergTable(table) &&
table.getStorageHandler().isPartitioned(table))`
would retrun true for unpartitioned iceberg and non iceberg table
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
