dengzhhu653 commented on code in PR #5398:
URL: https://github.com/apache/hive/pull/5398#discussion_r1724673173
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/DirectSqlUpdatePart.java:
##########
@@ -526,18 +519,18 @@ public Map<String, Map<String, String>>
updatePartitionColumnStatistics(Map<Stri
MetaStoreListenerNotifier.notifyEventWithDirectSql(transactionalListeners,
EventMessage.EventType.UPDATE_PARTITION_COLUMN_STAT_BATCH,
eventBatch, dbConn, sqlGenerator);
}
- dbConn.commit();
- committed = true;
+ closeDbConn(jdoConn);
Review Comment:
If the `tx.commit()` happens before the `closeDbConn(jdoConn)`, a
JDOUserException cloud see when commit the change:
`The Connection was acquired by the developer and must be closed before
using the persistence API`.
https://www.datanucleus.org/products/accessplatform_6_0/jdo/persistence.html#_user_connection
> You must return the connection back to the PersistenceManager before
performing any PersistenceManager operation. You do this by calling
conn.close(). If you don’t return the connection and try to perform an
PersistenceManager operation which requires the connection then a
JDOUserException is thrown.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
