deniskuzZ commented on code in PR #5398:
URL: https://github.com/apache/hive/pull/5398#discussion_r1727467342
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/DirectSqlUpdatePart.java:
##########
@@ -602,18 +594,18 @@ public long getNextCSIdForMPartitionColumnStatistics(long
numStats) throws MetaE
try (Statement statement = dbConn.createStatement()) {
statement.executeUpdate(query);
}
- dbConn.commit();
- committed = true;
+ closeDbConn(jdoConn);
+ tx.commit();
return maxCsId;
} catch (Exception e) {
LOG.error("Unable to getNextCSIdForMPartitionColumnStatistics", e);
throw new MetaException("Unable to
getNextCSIdForMPartitionColumnStatistics "
+ " due to: " + e.getMessage());
} finally {
- if (!committed) {
- rollbackDBConn(dbConn);
+ if (tx.isActive()) {
+ closeDbConn(jdoConn);
Review Comment:
why not wrap query execution in try-finally and close db connection there?
````
try (Statement statement = dbConn.createStatement()) {
statement.executeUpdate(query);
} finally {
closeDbConn(jdoConn);
}
tx.commit();
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
