deniskuzZ commented on code in PR #5409:
URL: https://github.com/apache/hive/pull/5409#discussion_r1736099979
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/mapreduce/IcebergSplit.java:
##########
@@ -70,14 +78,31 @@ public String[] getLocations() {
// getLocations() won't be accurate when called on worker nodes and will
always return "*"
if (locations == null && conf != null) {
boolean localityPreferred = conf.getBoolean(InputFormatConfig.LOCALITY,
false);
- locations = localityPreferred ? Util.blockLocations(task, conf) :
ANYWHERE;
+ locations = localityPreferred ? blockLocations(task, conf) : ANYWHERE;
} else {
locations = ANYWHERE;
}
return locations;
}
+ private static String[] blockLocations(ScanTaskGroup<FileScanTask> task,
Configuration conf) {
Review Comment:
due to the type change, we can't use `Util.blockLocations`? we'll probably
need to raise an iceberg PR to avoid code duplication
please add @TODO not to forget this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
