deniskuzZ commented on code in PR #5409:
URL: https://github.com/apache/hive/pull/5409#discussion_r1736132152
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/ReduceSinkOperator.java:
##########
@@ -304,9 +294,9 @@ public void process(Object row, int tag) throws
HiveException {
conf.getOutputKeyColumnNames(), numDistributionKeys, rowInspector);
valueObjectInspector = initEvaluatorsAndReturnStruct(valueEval,
conf.getOutputValueColumnNames(), rowInspector);
- partitionObjectInspectors = initEvaluators(partitionEval,
rowInspector);
+ partitionHashFunc =
conf.getPartitionFunction(initEvaluators(partitionEval, rowInspector));
Review Comment:
could we please extract `initEvaluators` into local var (i.e.
`ObjectInspector[] partitionObjectInspectors`)? and do the same for
`bucketObjectInspectors`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
