deniskuzZ commented on code in PR #5418:
URL: https://github.com/apache/hive/pull/5418#discussion_r1759153452
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergOutputCommitter.java:
##########
@@ -307,27 +307,24 @@ public void commitJobs(List<JobContext>
originalContextList, Operation operation
}
}
- private List<OutputTable> collectOutputs(List<JobContext> jobContextList) {
- return jobContextList.stream()
- .flatMap(jobContext ->
HiveIcebergStorageHandler.outputTables(jobContext.getJobConf()).stream()
- .map(output -> new OutputTable(
- HiveIcebergStorageHandler.catalogName(jobContext.getJobConf(),
output),
- output,
- SessionStateUtil.getResource(jobContext.getJobConf(), output)
+ private Multimap<OutputTable, JobContext> collectOutputs(List<JobContext>
jobContextList) {
+ Multimap<OutputTable, JobContext> outputs =
Review Comment:
We have multiple JobContext per OutputTable, nothing changed here, I just
used a more convenient collection. Update and Merge operations are represented
as multi-insert creating multiple contexts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
