deniskuzZ commented on code in PR #5418:
URL: https://github.com/apache/hive/pull/5418#discussion_r1763465801


##########
ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveStorageHandler.java:
##########
@@ -498,6 +493,11 @@ default FieldSchema getRowId() {
    * @return the list of columns that should be used as sort columns in the 
rewritten ACID query
    */
   default List<FieldSchema> 
acidSortColumns(org.apache.hadoop.hive.ql.metadata.Table table, Operation 
operation) {
+    return acidSortColumns(table, operation, false);
+  }
+
+  default List<FieldSchema> 
acidSortColumns(org.apache.hadoop.hive.ql.metadata.Table table, Operation 
operation, 
+      boolean emptyOrdering) {

Review Comment:
   refactored (removed new API) by adding fallback for merge operation in 
`HiveStorageHandler.acidSortColumns`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to