zhangbutao commented on code in PR #5375:
URL: https://github.com/apache/hive/pull/5375#discussion_r1804237180


##########
data/conf/hive-log4j2.properties:
##########
@@ -14,9 +14,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-status = INFO
 name = HiveLog4j2Test
-packages = org.apache.hadoop.hive.ql.log

Review Comment:
   Good explanation!
   
   > Since Hive has neither CI for JDK23 and JDK24 nor CI for GraalVM Native 
Image, we actually don't need to register a 
org.apache.logging.log4j.core.config.plugins.processor.PluginProcessor in 
pom.xml as 
https://logging.apache.org/log4j/2.x/manual/plugins.html#plugin-registry .
   
   BTW, if Hive wants to use JDK23 or JDK24, should we need to register the 
`PluginProcessor `?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to