linghengqian commented on code in PR #5375: URL: https://github.com/apache/hive/pull/5375#discussion_r1804250741
########## data/conf/hive-log4j2.properties: ########## @@ -14,9 +14,7 @@ # See the License for the specific language governing permissions and # limitations under the License. -status = INFO name = HiveLog4j2Test -packages = org.apache.hadoop.hive.ql.log Review Comment: > BTW, if Hive wants to use JDK23 or JDK24, should we need to register the PluginProcessor ? - The answer is yes. But I think most people will actually choose to set `-proc:full` for JDK `23` to make JDK `23` behave the same as JDK8. `-proc:full` is only available on `11.0.23`, `17.0.11`, JDK `21` - `24`. `-proc:full` is not available on any OpenJDK 8u, `-proc:full` is only available on Oracle's closed source JDK `8u411`. - For JDK23, we can set `<maven.compiler.proc>full</maven.compiler.proc>` in a separate Maven Profile to make JDK23 behave the same as JDK 8. Refer to https://github.com/apache/shardingsphere/pull/33224 for the solution. - I would say setting `<maven.compiler.proc>full</maven.compiler.proc>` is not useful for Hive, as I found that the master branch of Hive cannot be compiled with JDK22. This means that none of the unit tests will be affected. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
