deniskuzZ commented on code in PR #5483:
URL: https://github.com/apache/hive/pull/5483#discussion_r1804454864
##########
ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveStorageHandler.java:
##########
@@ -801,6 +801,11 @@ default List<FieldSchema>
getPartitionKeys(org.apache.hadoop.hive.ql.metadata.Ta
"for a table.");
}
+ default List<String>
getAllPartitionKeyNames(org.apache.hadoop.hive.ql.metadata.Table hmsTable) {
Review Comment:
i would prefer to extend an API
` List<FieldSchema> getPartitionKeys(hmsTable , boolean latestSpecOnly)`
not create a new one
and then similar to Table.getPartCols() extract the columnNames in a runner
`isPartitionKey`
##########
ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveStorageHandler.java:
##########
@@ -801,6 +801,11 @@ default List<FieldSchema>
getPartitionKeys(org.apache.hadoop.hive.ql.metadata.Ta
"for a table.");
}
+ default List<String>
getAllPartitionKeyNames(org.apache.hadoop.hive.ql.metadata.Table hmsTable) {
Review Comment:
i would prefer to extend an API
` List<FieldSchema> getPartitionKeys(hmsTable , boolean latestSpecOnly)`
not create a new one
and then similar to Table.getPartCols() extract the columnNames in a prunner
`isPartitionKey`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
