zratkai commented on code in PR #5483:
URL: https://github.com/apache/hive/pull/5483#discussion_r1804831511
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java:
##########
@@ -2018,6 +2018,19 @@ public List<String>
getPartitionNames(org.apache.hadoop.hive.ql.metadata.Table h
return IcebergTableUtil.getPartitionNames(icebergTable, partitionSpec,
true);
}
+ /**
+ * Returns a list of partition names
+ * @param hmsTable A Hive table instance.
+ * @return A list of partition names for all partitions
+ */
+ @Override
+ public List<String>
getPartitionNames(org.apache.hadoop.hive.ql.metadata.Table hmsTable) {
Review Comment:
We can not use it, since it gives back partition names instead of partition
keys, what needs here.
E.g. "event_src_trunc=BBB/event_time_month=2024-07" instead of "event_src".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
