zabetak commented on code in PR #5452:
URL: https://github.com/apache/hive/pull/5452#discussion_r1810597338
##########
ql/src/java/org/apache/hadoop/hive/ql/plan/mapper/PlanMapper.java:
##########
@@ -217,7 +230,11 @@ private void link(Object o1, Object o2, boolean mayMerge) {
}
if (mGroups.size() > 1) {
if (!mayMerge) {
- throw new RuntimeException("equivalence mapping violation");
+ LOG.warn("Illegally linking {} and {}", o1, o2);
+ if (failsWithIllegalLink) {
+ throw new RuntimeException("equivalence mapping violation");
+ }
+ isBroken.set(true);
Review Comment:
I don't fully understand the reasoning behind the new proposal.
From my perspective what I had in mind was something like the following:
```java
if (!mayMerge) {
LOG.warn("...");
return;
}
```
I am still trying to understand if it is necessary to invalidate the
`PlanMapper` or if we can just skip the "problematic" entry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
