okumin commented on code in PR #5452:
URL: https://github.com/apache/hive/pull/5452#discussion_r1818887896
##########
ql/src/java/org/apache/hadoop/hive/ql/plan/mapper/PlanMapper.java:
##########
@@ -217,7 +230,11 @@ private void link(Object o1, Object o2, boolean mayMerge) {
}
if (mGroups.size() > 1) {
if (!mayMerge) {
- throw new RuntimeException("equivalence mapping violation");
+ LOG.warn("Illegally linking {} and {}", o1, o2);
+ if (failsWithIllegalLink) {
+ throw new RuntimeException("equivalence mapping violation");
+ }
+ isBroken.set(true);
Review Comment:
@zabetak Does this align with your thoughts? If yes, I will push it to this
PR
- [new
commit](https://github.com/okumin/hive/commit/63cb34c83d7c34c3d1ff1a9847f53f913657e4d3)
- [entire
diff](https://github.com/okumin/hive/compare/49a6ff8b3cea365ceb62ea470c43fee2d1d252eb...63cb34c83d7c34c3d1ff1a9847f53f913657e4d3)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
