deniskuzZ commented on code in PR #5409:
URL: https://github.com/apache/hive/pull/5409#discussion_r1812651456


##########
ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java:
##########
@@ -260,6 +275,18 @@ public byte[] getBytesForHash() {
         return allBytes;
       }
     }
+
+    public byte[] getBytesForIdentity() {
+      if (inputSplit instanceof HashableInputSplit) {
+        return ((HashableInputSplit) inputSplit).getBytesForHash();
+      } else {
+        byte[] pathBytes = getPath().toString().getBytes();

Review Comment:
   not sure if that's an optimal approach. for example iceberg uses reverse 
order comparison: 
https://github.com/apache/iceberg/blob/a8ec43d975d8d3bbacb6880b487208b00cb7361f/api/src/main/java/org/apache/iceberg/types/Comparators.java#L364
 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

Reply via email to