deniskuzZ commented on code in PR #5409:
URL: https://github.com/apache/hive/pull/5409#discussion_r1813105103
##########
ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConvertJoinMapJoin.java:
##########
@@ -1521,12 +1570,22 @@ private static int estimateNumBuckets(JoinOperator
joinOp, boolean useOpTraits)
int estimatedBuckets = -1;
for (Operator<? extends OperatorDesc>parentOp :
joinOp.getParentOperators()) {
- if (parentOp.getOpTraits().getNumBuckets() > 0) {
- numBuckets = (numBuckets < parentOp.getOpTraits().getNumBuckets()) ?
- parentOp.getOpTraits().getNumBuckets() : numBuckets;
+ final OpTraits parentOpTraits = parentOp.getOpTraits();
+ if (parentOpTraits.getNumBuckets() > 0) {
+ numBuckets = (numBuckets < parentOpTraits.getNumBuckets()) ?
+ parentOpTraits.getNumBuckets() : numBuckets;
+ }
+
+ if (!(parentOp instanceof ReduceSinkOperator)) {
Review Comment:
why not filter upfront
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
