deniskuzZ commented on code in PR #5534:
URL: https://github.com/apache/hive/pull/5534#discussion_r1837277786
##########
llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java:
##########
@@ -516,21 +471,13 @@ private static Object
determineFileId(Supplier<FileSystem> fsSupplier, FileSplit
* Closes the stripe readers (on error).
*/
private void cleanupReaders() {
- if (stripeReader != null) {
- try {
- stripeReader.close();
- } catch (IOException ex) {
- // Ignore.
- }
- }
- if (rawDataReader != null && isRawDataReaderOpen) {
- try {
- rawDataReader.close();
- rawDataReader = null;
- } catch (IOException ex) {
- // Ignore.
- }
+ try {
+ IOUtils.close(stripeReader, rawDataReader, orcReader);
+ } catch (IOException e) {
+ LOG.warn("Error while closing readers: ", e);
}
+ rawDataReader = null;
Review Comment:
what about `stripeReader` should we set it to null as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
