harishjp commented on code in PR #5534:
URL: https://github.com/apache/hive/pull/5534#discussion_r1837315800
##########
llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java:
##########
@@ -531,6 +531,15 @@ private void cleanupReaders() {
// Ignore.
}
}
+
+ if (orcReader != null) {
Review Comment:
The implementation seems to be written such that stop() can be called when
callInternal is executing, please look at how isStopped is being sent as
AtomicBoolean and isStopped checks are in multiple places during callInternal,
isn't that right? If yes then we need the new state, how else do you know that
stop() is not being called when callInternal is executing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
