deniskuzZ commented on code in PR #5537:
URL: https://github.com/apache/hive/pull/5537#discussion_r1838153066
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java:
##########
@@ -15840,25 +15849,34 @@ private QueryResultsCache.QueryInfo
createCacheQueryInfoForQuery(QueryResultsCac
/**
* Some initial checks for a query to see if we can look this query up in
the results cache.
*/
- private boolean queryTypeCanUseCache() {
- if (this.qb == null || this.qb.getParseInfo() == null) {
+ private boolean queryTypeCanUseCache(QB qbParam) {
+ if (qbParam == null || qbParam.getParseInfo() == null) {
return false;
}
if (this instanceof ColumnStatsSemanticAnalyzer) {
// Column stats generates "select compute_stats() .." queries.
// Disable caching for these.
+ LOG.debug("Query type cannot use cache (ColumnStatsSemanticAnalyzer)");
return false;
}
if (queryState.getHiveOperation() != HiveOperation.QUERY) {
+ LOG.debug("Query type cannot use cache (HiveOperation is not a QUERY)");
return false;
}
- if (Optional.of(qb.getParseInfo()).filter(pi ->
+ if (Optional.of(qbParam.getParseInfo()).filter(pi ->
pi.isAnalyzeCommand() || pi.hasInsertTables() ||
pi.isInsertOverwriteDirectory())
.isPresent()) {
+ LOG.debug("Query type cannot use cache (analyze, insert, or IOWD)");
return false;
}
// HIVE-19096 - disable for explain and explain analyze
- return ctx.getExplainAnalyze() == null;
+ if (ctx.getExplainAnalyze() != null) {
+ LOG.debug("Query type cannot use cache (explain analyze command)");
+ return false;
+ }
+
+ LOG.debug("Query type can use cache");
Review Comment:
i think this log message is redundant
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
