abstractdog commented on PR #5537: URL: https://github.com/apache/hive/pull/5537#issuecomment-2470784761
pushed https://github.com/apache/hive/pull/5537/commits/392c9b9b5aa71a730c618604c330e94e9fadb5a4 thanks for the good catch @deniskuzZ , looks like almost all the signature changes were unnecessary, except where the actual issue happened: getDestinationFilePath, where this.qb was silently used I also changed qb param to qbParam in genPlan, it's dangerous that a param can hide the field in java, especially in this context -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
