deniskuzZ commented on code in PR #5537:
URL: https://github.com/apache/hive/pull/5537#discussion_r1838759395
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java:
##########
@@ -15840,25 +15840,33 @@ private QueryResultsCache.QueryInfo
createCacheQueryInfoForQuery(QueryResultsCac
/**
* Some initial checks for a query to see if we can look this query up in
the results cache.
*/
- private boolean queryTypeCanUseCache() {
- if (this.qb == null || this.qb.getParseInfo() == null) {
+ private boolean queryTypeCanUseCache(QB qbParam) {
Review Comment:
minor: I would have used simply `qb`. I know it hides the instance param,
but maybe we could refactor same thing everywhere in diff PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
