InvisibleProgrammer commented on code in PR #5544:
URL: https://github.com/apache/hive/pull/5544#discussion_r1843875748
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java:
##########
@@ -569,7 +569,8 @@ public int execute() {
}
releaseLocks(tbd);
}
-
+ long moveFilesDuration = perfLogger.getDuration(PerfLogger.FILE_MOVES);
Review Comment:
Two questions about this:
1.: This method already contains a perfLogEnd call:
```java
// if _blob_files_kept is present, use it to move the files. Else fall
back to normal case.
if (moveFilesUsingManifestFile(fs, sourcePath, targetPath)) {
perfLogger.perfLogEnd("MoveTask", PerfLogger.FILE_MOVES);
return;
}
```
Does it stops the perfLogger? If yes, how that change will behave in that
case?
2: perfLogEnd is already called at line 196. Can it affect the output of
this getDuration call?
##########
ql/src/java/org/apache/hadoop/hive/ql/stats/BasicStatsTask.java:
##########
Review Comment:
Leftover
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
