abstractdog commented on code in PR #5544:
URL: https://github.com/apache/hive/pull/5544#discussion_r1843918053
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java:
##########
@@ -569,7 +569,8 @@ public int execute() {
}
releaseLocks(tbd);
}
-
+ long moveFilesDuration = perfLogger.getDuration(PerfLogger.FILE_MOVES);
Review Comment:
1. it doesn't stop, just registers and endTime for the duration of FILE_MOVES
2. yeah, depending on the outcome, the ending time should still be
registered anyways
possible refactoring is to fully encapsulate the whole movetask behavior to
have a single begin + end call
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
