difin commented on code in PR #5540:
URL: https://github.com/apache/hive/pull/5540#discussion_r1932768447
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/compaction/IcebergQueryCompactor.java:
##########
@@ -62,20 +63,32 @@ public boolean run(CompactorContext context) throws
IOException, HiveException,
Table icebergTable = IcebergTableUtil.getTable(conf, table.getTTable());
String compactionQuery;
String orderBy = ci.orderByClause == null ? "" : ci.orderByClause;
+ String fileSizeCond = null;
+
+ if (ci.type == CompactionType.MINOR) {
Review Comment:
I don't think it is worth currently, because the only difference between
minor and major compaction is that minor compaction adds files size threshold
to compaction query. Maybe it make sense to do in the refactor PR where we
implement compaction QueryBuilder
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
