difin commented on code in PR #5540:
URL: https://github.com/apache/hive/pull/5540#discussion_r1932801821
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergOutputCommitter.java:
##########
@@ -598,9 +605,10 @@ private void commitWrite(Table table, String branchName,
Long snapshotId, long s
* @param partitionPath The path of the compacted partition
*/
private void commitCompaction(Table table, Long snapshotId, long startTime,
FilesForCommit results,
- String partitionPath) {
- List<DataFile> existingDataFiles =
IcebergCompactionUtil.getDataFiles(table, partitionPath);
- List<DeleteFile> existingDeleteFiles =
IcebergCompactionUtil.getDeleteFiles(table, partitionPath);
+ String partitionPath, long fileSizeThreshold) {
+ List<DataFile> existingDataFiles =
IcebergCompactionUtil.getDataFiles(table, partitionPath, fileSizeThreshold);
+ List<DeleteFile> existingDeleteFiles = fileSizeThreshold == -1 ?
Review Comment:
'-1' means that there is no fileSizeThreshold (major compaction case
currently).
for minor compaction it will have a positive value.
_why not pass compaction type instead of fileSizeThreshold?_ Because then
we will need to pass one more property in addition to fileSizeThreshold which
will still be required for minor compaction.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
