kasakrisz commented on code in PR #5690:
URL: https://github.com/apache/hive/pull/5690#discussion_r1990992126
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java:
##########
@@ -1166,13 +1166,15 @@ public static PrimitiveCategory
getPrimitiveCommonCategory(TypeInfo a, TypeInfo
}
}
- // Handle date-string common category and numeric-string common category
- if (pgA == PrimitiveGrouping.STRING_GROUP
- && (pgB == PrimitiveGrouping.DATE_GROUP || pgB ==
PrimitiveGrouping.NUMERIC_GROUP)) {
+ // Handle common category for date-string, numeric-string, and
boolean-string types
+ Set<PrimitiveGrouping> stringFriendlyGroup = new HashSet<>(
+ Arrays.asList(PrimitiveGrouping.DATE_GROUP,
PrimitiveGrouping.NUMERIC_GROUP, PrimitiveGrouping.BOOLEAN_GROUP)
Review Comment:
Could you please extract this to a constant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
