kasakrisz commented on code in PR #5690:
URL: https://github.com/apache/hive/pull/5690#discussion_r1995037392
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java:
##########
@@ -273,6 +273,10 @@ public final class FunctionRegistry {
"=", "==", "<=>", "!=", "<>", "<", "<=", ">", ">=",
"index"));
}
+
+ private static final Set<PrimitiveGrouping> stringFriendlyGroups = new
HashSet<>(
Review Comment:
nit. Constant names are usually written by all capital letters:
`STRING_FRIENDLY_GROUPS`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
