dengzhhu653 commented on code in PR #5699:
URL: https://github.com/apache/hive/pull/5699#discussion_r2004568800


##########
service/src/java/org/apache/hive/service/cli/thrift/ThriftBinaryCLIService.java:
##########
@@ -100,7 +102,15 @@ protected void initServer() {
 
       // Server args
       int maxMessageSize = 
hiveConf.getIntVar(HiveConf.ConfVars.HIVE_SERVER2_THRIFT_MAX_MESSAGE_SIZE);
-      TThreadPoolServer.Args sargs = new 
TThreadPoolServer.Args(serverSocket).processorFactory(processorFactory)
+      TThreadPoolServer.Args sargs = new TThreadPoolServer.Args(new 
TServerSocket(serverSocket.getServerSocket()) {

Review Comment:
   this class is renamed from `TServerSocketKeepAlive` and puts the thrift 
limit this PR, which in HMS long ago, 
   the HS2 doesn't need it I guess because the jdbc client will refresh the 
connection(to poll the operation status) every 
`hive.server2.long.polling.timeout`(default 5s).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to