dengzhhu653 commented on code in PR #5699:
URL: https://github.com/apache/hive/pull/5699#discussion_r2004585810
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetastoreTServerSocket.java:
##########
@@ -29,8 +32,32 @@
* accepted sockets.
*
*/
-public class TServerSocketKeepAlive extends TServerSocket {
- public TServerSocketKeepAlive(TServerSocket serverSocket) throws
TTransportException {
+public class MetastoreTServerSocket extends TServerSocket {
+ private final Configuration configuration;
+
+ public MetastoreTServerSocket(TServerSocket serverSocket,
+ Configuration conf) throws TTransportException {
super(serverSocket.getServerSocket());
+ this.configuration = Objects.requireNonNull(conf);
+ }
+
+ @Override
+ public TSocket accept() throws TTransportException {
+ TSocket ts = super.accept();
+ boolean keepAlive = MetastoreConf.getBoolVar(configuration,
MetastoreConf.ConfVars.TCP_KEEP_ALIVE);
+ if (keepAlive) {
+ try {
+ ts.getSocket().setKeepAlive(true);
+ } catch (SocketException e) {
+ throw new TTransportException(e);
+ }
+ }
+ // for testing purpose, get the maxThriftMessageSize from the
configuration for every new connection
Review Comment:
For the sake of tests, I make the `maxThriftMessageSize` can change
dynamically based on the test need, compared to initialize the value at HMS
startup and add an extra method to change this limit for test only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
