zhangbutao commented on code in PR #5669:
URL: https://github.com/apache/hive/pull/5669#discussion_r2015834994
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/security/TokenStoreDelegationTokenSecretManager.java:
##########
@@ -105,7 +105,11 @@ public byte[] retrievePassword(DelegationTokenIdentifier
identifier) throws Inva
if (info == null) {
throw new InvalidToken("token expired or does not exist: " +
identifier);
}
- renewIfRequired(System.currentTimeMillis(), identifier, info);
+ try {
+ renewIfRequired(identifier, info);
+ } catch (InvalidToken e) {
+ LOGGER.warn("Failed to renew token: " + identifier, e);
Review Comment:
If the renew token fails, will the user's job fail?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
