vikramahuja1001 commented on code in PR #5669:
URL: https://github.com/apache/hive/pull/5669#discussion_r2024165274
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/security/TokenStoreDelegationTokenSecretManager.java:
##########
@@ -105,7 +105,11 @@ public byte[] retrievePassword(DelegationTokenIdentifier
identifier) throws Inva
if (info == null) {
throw new InvalidToken("token expired or does not exist: " +
identifier);
}
- renewIfRequired(System.currentTimeMillis(), identifier, info);
+ try {
+ renewIfRequired(identifier, info);
+ } catch (InvalidToken e) {
+ LOGGER.warn("Failed to renew token: " + identifier, e);
Review Comment:
No, ongoing user's job will not fail as it does not require the token. There
are 2 cases here:
1. If current time < renewal time : In this case it will never try to go for
renewal.
2. current time >= renewal time : in this case it will attempt for token
renewal. The renewal here is failsafe in case if the session ever requires the
delegation token later in it's lifeline.
This will have no impact on the user's job.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
