deniskuzZ commented on code in PR #5789:
URL: https://github.com/apache/hive/pull/5789#discussion_r2079890415
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java:
##########
@@ -921,7 +921,8 @@ public DynamicPartitionCtx createDPContext(
List<Function<List<ExprNodeDesc>, ExprNodeDesc>> customSortExprs =
Lists.newLinkedList();
dpCtx.setCustomSortExpressions(customSortExprs);
- if (table.spec().isPartitioned()) {
+ if (table.spec().isPartitioned() &&
+
hiveConf.getIntVar(ConfVars.HIVE_OPT_SORT_DYNAMIC_PARTITION_THRESHOLD) == 1) {
Review Comment:
The below reducer isn't required when
HIVE_OPT_SORT_DYNAMIC_PARTITION_THRESHOLD is disabled and we want to use
FanoutWriter
````
Reducer 2
Execution mode: vectorized, llap
Reduce Operator Tree:
Select Operator
expressions: VALUE._col0 (type: int), VALUE._col1 (type:
string), KEY._col2 (type: string)
outputColumnNames: _col0, _col1, _col2
File Output Operator
compressed: false
Dp Sort State: PARTITION_SORTED
Statistics: Num rows: 5 Data size: 890 Basic stats:
COMPLETE Column stats: COMPLETE
table:
input format:
org.apache.iceberg.mr.hive.HiveIcebergInputFormat
output format:
org.apache.iceberg.mr.hive.HiveIcebergOutputFormat
serde: org.apache.iceberg.mr.hive.HiveIcebergSerDe
name: default.ice_dst
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
