SourabhBadhya commented on code in PR #5789:
URL: https://github.com/apache/hive/pull/5789#discussion_r2093303524
##########
ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java:
##########
@@ -1368,7 +1368,7 @@ public static void
createMRWorkForMergingFiles(FileSinkOperator fsInput,
// NOTE: we should gather stats in MR1 rather than MR2 at merge job since
we don't
// know if merge MR2 will be triggered at execution time
MoveWork dummyMv = null;
- if (srcMmWriteId == null) {
+ if (srcMmWriteId == null && !fsInputDesc.isIcebergTable()) {
Review Comment:
Yeah, moveTask for Iceberg is handled in a different way. Its ok for now,
however ideally this should be handled on the move side. Was there any
mergeWork created here?
##########
ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java:
##########
@@ -1368,7 +1368,7 @@ public static void
createMRWorkForMergingFiles(FileSinkOperator fsInput,
// NOTE: we should gather stats in MR1 rather than MR2 at merge job since
we don't
// know if merge MR2 will be triggered at execution time
MoveWork dummyMv = null;
- if (srcMmWriteId == null) {
+ if (srcMmWriteId == null && !fsInputDesc.isIcebergTable()) {
Review Comment:
@deniskuzZ Yeah, moveTask for Iceberg is handled in a different way. Its ok
for now, however ideally this should be handled on the move side. Was there any
mergeWork created here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
