jjiang037 commented on code in PR #5819: URL: https://github.com/apache/hive/pull/5819#discussion_r2153170594
########## ql/src/test/org/apache/hadoop/hive/ql/security/authorization/plugin/metastore/TestHiveMetaStoreAuthorizer.java: ########## @@ -388,7 +484,6 @@ public void testGetDatabaseObjects_UnauthorizedUser() throws Exception { GetDatabaseObjectsRequest request = new GetDatabaseObjectsRequest(); request.setCatalogName("hive"); hmsHandler.get_databases_req(request); - fail("Expected exception for unauthorized user"); Review Comment: It was removed intentionally to resolve this concern: https://github.com/apache/hive/pull/5819#discussion_r2141139115 The authorization system should throw an exception. If it doesn't throw an exception, something is fundamentally broken, and the test framework will appropriately fail. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org