jjiang037 commented on code in PR #5819:
URL: https://github.com/apache/hive/pull/5819#discussion_r2153219454
##########
ql/src/test/org/apache/hadoop/hive/ql/security/authorization/plugin/metastore/TestHiveMetaStoreAuthorizer.java:
##########
@@ -547,76 +642,29 @@ public void testUnAuthorizedCause() {
.build(conf);
hmsHandler.create_database(db);
} catch (Exception e) {
- String[] rootCauseStackTrace = ExceptionUtils.getRootCauseStackTrace(e);
- assertTrue(Arrays.stream(rootCauseStackTrace)
- .anyMatch(stack ->
stack.contains(DummyHiveAuthorizer.class.getName())));
- }
- }
-
- @Test
- public void testTableFilterContextWithOwnership() throws Exception {
Review Comment:
I initially removed this test believing MockMetaStoreFilterHook provided
equivalent coverage since both handle ownership-based filtering. After deeper
analysis, I'm restoring this test because it validates the data transformation
layer that MockMetaStoreFilterHook cannot cover. Specifically, it ensures that
when converting TableMeta objects to HivePrivilegeObjects, ownership
information is correctly preserved during transformation. This complements
MockMetaStoreFilterHook, which tests the actual filtering decisions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
