soumyakanti3578 commented on code in PR #5790:
URL: https://github.com/apache/hive/pull/5790#discussion_r2155279470
##########
ql/src/test/results/clientpositive/llap/alter_table_column_stats.q.out:
##########
@@ -1105,7 +1105,6 @@ Retention: 0
#### A masked pattern was here ####
Table Type: MANAGED_TABLE
Table Parameters:
- COLUMN_STATS_ACCURATE {\"BASIC_STATS\":\"true\"}
Review Comment:
I see that we are removing `COLUMN_STATS_ACCURATE` here, however, in the
corresponding q file, I see this comment:
```
-- rename a partition should not change its table, partition, and column
stats
alter table statsdb1.testpart1 partition (part = 'part1') rename to
partition (part = 'part11');
describe formatted statsdb1.testpart1;
```
So this seems like a behavioral change. I just want us to be sure that this
is what we intend to do as I see several other similar changes just below which
were due to renaming/replacing columns.
##########
ql/src/test/results/clientpositive/llap/alter_table_column_stats.q.out:
##########
@@ -1476,7 +1471,7 @@ Database: statsdb1
Table: testpart1
#### A masked pattern was here ####
Partition Parameters:
- COLUMN_STATS_ACCURATE
{\"BASIC_STATS\":\"true\",\"COLUMN_STATS\":{\"col1\":\"true\",\"col2\":\"true\"}}
+ COLUMN_STATS_ACCURATE {}
Review Comment:
Here we are printing empty `COLUMN_STATS_ACCURATE`. If it is easy to remove
them, maybe we should do that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
