dengzhhu653 commented on code in PR #5790:
URL: https://github.com/apache/hive/pull/5790#discussion_r2200290143
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java:
##########
@@ -7502,6 +7502,15 @@ public boolean
delete_column_statistics_req(DeleteColumnStatisticsRequest req) t
}
}
}
+ // on the table level, partially delete(update) table level parameter
COLUMN_STATS_ACCURATE
+ if (colNames == null || colNames.isEmpty()){
+ // remove all column names in parameter COLUMN_STATS_ACCURATE
+ StatsSetupConst.clearColumnStatsState(table.getParameters());
+ } else {
+ // remove the deleted column names in parameter COLUMN_STATS_ACCURATE
+ StatsSetupConst.removeColumnStatsState(table.getParameters(),
colNames);
+ }
+ rawStore.alterTable(parsedDbName[CAT_NAME], parsedDbName[DB_NAME],
tableName, table, null);
Review Comment:
we might need to add the new interface in RawStore, example `void
updateTableParam(long tableId, String paramKey, String newParamValue)` to
update the table's parameters
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java:
##########
@@ -7502,6 +7502,15 @@ public boolean
delete_column_statistics_req(DeleteColumnStatisticsRequest req) t
}
}
}
+ // on the table level, partially delete(update) table level parameter
COLUMN_STATS_ACCURATE
+ if (colNames == null || colNames.isEmpty()){
+ // remove all column names in parameter COLUMN_STATS_ACCURATE
+ StatsSetupConst.clearColumnStatsState(table.getParameters());
+ } else {
+ // remove the deleted column names in parameter COLUMN_STATS_ACCURATE
+ StatsSetupConst.removeColumnStatsState(table.getParameters(),
colNames);
+ }
+ rawStore.alterTable(parsedDbName[CAT_NAME], parsedDbName[DB_NAME],
tableName, table, null);
Review Comment:
we might need to add a new interface in RawStore, example `void
updateTableParam(long tableId, String paramKey, String newParamValue)` to
update the table's parameters
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
