zabetak commented on code in PR #5894:
URL: https://github.com/apache/hive/pull/5894#discussion_r2164273796
##########
pom.xml:
##########
@@ -1747,6 +1747,24 @@
</rules>
</configuration>
</execution>
+ <!-- Only remove this rule if you confirmed that adding jupiter
dependency -->
+ <!-- to the project won't make unit tests silently skipped -->
Review Comment:
This comment would be more helpful if it was part of the failure. How about
putting it in `<message>...</message>`
##########
standalone-metastore/pom.xml:
##########
@@ -610,6 +610,47 @@
</excludes>
</configuration>
</plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-enforcer-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>enforce-banned-dependencies</id>
+ <goals>
+ <goal>enforce</goal>
+ </goals>
+ <configuration>
+ <rules>
+ <bannedDependencies>
+ <excludes>
+ <!--LGPL licenced library-->
+ <exclude>com.google.code.findbugs:annotations</exclude>
+ </excludes>
+ </bannedDependencies>
+ </rules>
+ <fail>true</fail>
+ </configuration>
+ </execution>
+ <!-- Only remove this rule if you confirmed that adding jupiter
dependency -->
+ <!-- to the project won't make unit tests silently skipped -->
Review Comment:
Same comment regarding the message.
##########
standalone-metastore/pom.xml:
##########
@@ -610,6 +610,47 @@
</excludes>
</configuration>
</plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-enforcer-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>enforce-banned-dependencies</id>
+ <goals>
+ <goal>enforce</goal>
+ </goals>
+ <configuration>
+ <rules>
+ <bannedDependencies>
+ <excludes>
+ <!--LGPL licenced library-->
+ <exclude>com.google.code.findbugs:annotations</exclude>
+ </excludes>
+ </bannedDependencies>
+ </rules>
+ <fail>true</fail>
Review Comment:
I think the default is true so possible we could skip this.
##########
standalone-metastore/pom.xml:
##########
@@ -610,6 +610,47 @@
</excludes>
</configuration>
</plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-enforcer-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>enforce-banned-dependencies</id>
+ <goals>
+ <goal>enforce</goal>
+ </goals>
+ <configuration>
+ <rules>
+ <bannedDependencies>
+ <excludes>
+ <!--LGPL licenced library-->
+ <exclude>com.google.code.findbugs:annotations</exclude>
+ </excludes>
+ </bannedDependencies>
+ </rules>
+ <fail>true</fail>
+ </configuration>
+ </execution>
+ <!-- Only remove this rule if you confirmed that adding jupiter
dependency -->
+ <!-- to the project won't make unit tests silently skipped -->
+ <execution>
+ <id>ban-jupiter</id>
Review Comment:
Why do we want to put the rule in a separate execution? We could merge
`enforce-banned-dependencies` and `ban-jupiter` and it would lead to less
boilerplate code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
