abstractdog commented on PR #5894: URL: https://github.com/apache/hive/pull/5894#issuecomment-3004197426
> I like the idea but based on the test failures it seems that we already have jupiter dependencies in the project so we have to revisit those. > > Other than that left some minor suggestions for potential improvements. thanks for the comments, finally, even if I wanted to ban the dependency globally so bad, I had to face that we do use the jupiter api extensively in some modules, so I ended banning it from itests/hive-unit, where it caused the problem all the time there how I ended up with: https://github.com/apache/hive/pull/5894/commits/8e57d3b9f75bbfd8f59396ccb3d25090600370e7 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
