deniskuzZ commented on code in PR #5868:
URL: https://github.com/apache/hive/pull/5868#discussion_r2164776138
##########
ql/src/java/org/apache/hadoop/hive/ql/io/BatchToRowReader.java:
##########
@@ -518,7 +521,8 @@ public static TimestampWritableV2
nextTimestamp(ColumnVector vector,
result = (TimestampWritableV2) previous;
}
TimestampColumnVector tcv = (TimestampColumnVector) vector;
- result.setInternal(tcv.time[row], tcv.nanos[row]);
+ result.set(Timestamp.ofEpochSecond(Math.floorDiv(tcv.time[row], 1000L),
tcv.nanos[row],
+ tcv.isUTC() ? ZoneOffset.UTC : ZoneId.systemDefault()));
Review Comment:
@vrozov, can you refactor
````
protected RecordReaderImpl(ReaderImpl fileReader,
Reader.Options options, final Configuration conf) throws IOException {
super(fileReader, options);
...
context = new ReaderContext(fileReader.isUTC());
}
private static class ReaderContext {
private boolean useUTCTimestamp = false;
private ReaderContext(boolean useUTCTimestamp) {
this.useUTCTimestamp = useUTCTimestamp;
}
public boolean getUseUTCTimestamp() {
return this.useUTCTimestamp;
}
}
static Object nextValue(ColumnVector vector,
int row,
TypeDescription schema,
Object previous,
ReaderContext context) {
case TIMESTAMP:
return nextTimestamp(vector, row, previous,
context.getUseUTCTimestamp()? ZoneOffset.UTC :
ZoneId.systemDefault());
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
