vrozov commented on code in PR #5868:
URL: https://github.com/apache/hive/pull/5868#discussion_r2164686315
##########
ql/src/java/org/apache/hadoop/hive/ql/io/orc/RecordReaderImpl.java:
##########
@@ -73,6 +76,12 @@ protected RecordReaderImpl(ReaderImpl fileReader,
} else {
batch = this.schema.createRowBatch();
}
+ // Workaround for ORC not initializing TimestampColumnVector properly
+ for (int i = 0; i < batch.numCols; ++i) {
+ if (batch.cols[i] instanceof TimestampColumnVector) {
+ ((TimestampColumnVector) batch.cols[i]).setIsUTC(fileReader.isUTC());
Review Comment:
I think that it is only necessary for ORC readers. Note that ORC
`TimestampTreeReader` sets the UTC flag in
https://github.com/apache/orc/blob/29c1b37955e3423681304c6e9eb3fe7884ba57bc/java/core/src/java/org/apache/orc/impl/TreeReaderFactory.java#L1364,
so the workaround is necessary because `TimestampFromAnyIntegerTreeReader` and
similar ORC `ConvertTreeReader` don't set the flag correctly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
