deniskuzZ commented on PR #5868: URL: https://github.com/apache/hive/pull/5868#issuecomment-3006629079
> That can be easily fixed. A few more loops and type checks? > Note that your solution assumes that ORC readers use exclusively `fileReader.readerOptions()` to set `isUTC` flag in `TimestampColumnVector` Just to clarify, your solution does not make use of the `useUTCTimestamp` flag configured through readerOptions()? > Another issue with your PR is that all that propagation of `fileReader.readerOptions()` to `RecordReaderImpl` is not necessary (obsolete) once [apache/orc#2300](https://github.com/apache/orc/pull/2300) is fixed. Are you saying your solution doesn't encounter this issue? LOL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
